OllamaChatOptions getOutputSchema() throws exception#5976
Merged
tzolov merged 1 commit intospring-projects:mainfrom May 8, 2026
Merged
OllamaChatOptions getOutputSchema() throws exception#5976tzolov merged 1 commit intospring-projects:mainfrom
tzolov merged 1 commit intospring-projects:mainfrom
Conversation
The OllamaChatOptions implementation breaks the nullability contract in the parent StructuredOutputOptions interface, throwing an exception instead of returning null if there's no format specified. Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Contributor
Author
|
I noticed that the native structured output integration tests for Ollama are currently failing on the main branch (so, not related to the changes in this PR). I opened a separate issue to look into that: #5977 |
tzolov
approved these changes
May 8, 2026
Contributor
tzolov
left a comment
tzolov
left a comment
There was a problem hiding this comment.
Nice catch. Thanks @ThomasVitale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OllamaChatOptions implementation breaks the nullability contract in the parent StructuredOutputOptions interface, throwing an exception instead of returning null if there's no format specified.