Sanitize Spring Boot related dependencies#6088
Closed
ericbottard wants to merge 2 commits into
Closed
Conversation
With this commit, the main codebase is fixed so that the spring-ai core modules do NOT depend on spring boot. Only the xx-autoconfigure-yy modules should introduce a dependency on spring boot, and only the xx-starter-yy modules should introduce a dependency on the corresponding xx-autoconfigure-yy module. It is fine for modules to depend on spring boot test starters though. Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
Also add a maven enforcer rule to ensure the codebase does not depend on spring-boot. Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
sdeleuze
approved these changes
May 20, 2026
| <artifactId>spring-boot-autoconfigure-processor</artifactId> | ||
| <optional>true</optional> | ||
| </dependency> | ||
|
|
Contributor
There was a problem hiding this comment.
Does not hurt but multiple empty lines could be removed here
sdeleuze
changed the title
ilayaperumalg
approved these changes
May 20, 2026
Member
|
Rebased, squashed and merged via 99b6bce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit, we ensure that