Enforce single ToolAdvisor invariant in DefaultChatClient#6111
Closed
tzolov wants to merge 1 commit into
Closed
Conversation
Contributor
tzolov
commented
May 21, 2026
tzolov
commented
- Add validateSingleToolAdvisor() to throw IllegalStateException when more than one ToolAdvisor is present in the advisor chain after auto-registration.
- Delegate legacy toolCallbacks/toolContext methods to tools(ToolSpec) to consolidate validation.
- Remove the streaming boolean from buildAdvisorChain since streamToolCallResponses is now pre-configured on the builder.
- Add validateSingleToolAdvisor() to throw IllegalStateException when more than one ToolAdvisor is present in the advisor chain after auto-registration. - Delegate legacy toolCallbacks/toolContext methods to tools(ToolSpec) to consolidate validation. - Remove the streaming boolean from buildAdvisorChain since streamToolCallResponses is now pre-configured on the builder. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Contributor
|
Merged upstream via 2f48e9c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.