Simplify ToolCallAdvisor stream aggregation by removing publish() multicast#6195
Merged
Conversation
…ticast Replace the publish()-based dual-branch pattern with a straightforward sequential aggregation: aggregate the response first, then defer the tool-call recursion. Also extract ChatClientMessageAggregator as a static field to avoid repeated instantiation per stream invocation. Closes spring-projects#6017 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
chemicL
approved these changes
May 28, 2026
Comment on lines
+260
to
+261
| // Propagate this round's observation as the parent for inner-chain advisors | ||
| // (e.g. ChatModelStreamAdvisor) so their spans are correctly nested. |
Member
There was a problem hiding this comment.
This comment doesn't seem justified or reflecting what actually happens? I mean it might be the case but it couples the comment with whatever happens in the chainCopy.nextStream if that is the internal behaviour. Let's bring back the previous comment maybe?
Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the publish()-based dual-branch pattern with a straightforward sequential aggregation: aggregate the response first, then defer the tool-call recursion.
Also extract ChatClientMessageAggregator as a static field to avoid repeated instantiation per stream invocation.
Closes #6017