Refactor toOptions method for vendor-specific autoconfiguration properties#6248
Closed
nicolaskrier wants to merge 1 commit into
Closed
Refactor toOptions method for vendor-specific autoconfiguration properties#6248nicolaskrier wants to merge 1 commit into
nicolaskrier wants to merge 1 commit into
Conversation
nicolaskrier
force-pushed
the
refactor-to-options
branch
2 times, most recently
from
b27ce9e to
96e1a09
Compare
…rties - Remove unnecessary null cheks - Make some with methods nullable for option builder - Handle default values in options constructor - Rename with methods from N to n See spring-projects#6218 Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com>
nicolaskrier
force-pushed
the
refactor-to-options
branch
from
96e1a09 to
91dcae8
Compare
sdeleuze
pushed a commit
to sdeleuze/spring-ai
that referenced
this pull request
Jun 4, 2026
…rties - Remove unnecessary null cheks - Make some with methods nullable for option builder - Handle default values in options constructor See spring-projects#6218 Closes spring-projects#6248 Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com> Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
pushed a commit
to sdeleuze/spring-ai
that referenced
this pull request
Jun 4, 2026
…rties - Remove unnecessary null cheks - Make some with methods nullable for option builder - Handle default values in options constructor See spring-projects#6218 Closes spring-projects#6248 Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com> Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
Contributor
|
Thanks, merged with the |
Contributor
Author
|
You're welcome and thank you for the feedback! I’ll align with your approach and split such impactful changes into a dedicated PR next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposed milestone
2.0.0-RC1
Related work
#6218