Remove duplicate builder overrides in OpenAiChatOptions#6255
Merged
sdeleuze merged 5 commits intoJun 2, 2026
Conversation
guanxuc
force-pushed
the
openai-chatoptions-duplicate
branch
from
663ab80 to
7f7579c
Compare
Contributor
|
Please refine to fix tests and keep the defensive copy in |
Contributor
Author
|
@sdeleuze Thanks for you review and good advice, I will fix it soon. |
guanxuc
force-pushed
the
openai-chatoptions-duplicate
branch
2 times, most recently
from
7622efd to
711220d
Compare
- Removed toolCallbacks, toolNames, toolContext, internalToolExecutionEnabled, frequencyPenalty, presencePenalty, stopSequences, temperature, topK, topP overrides from the OpenAiChatOptions.Builder class. - Fixed combineWith() to properly merge toolCallbacks and toolNames instead of replacing them. Signed-off-by: guanxu <1510424541@qq.com>
Signed-off-by: guanxu <1510424541@qq.com>
guanxuc
force-pushed
the
openai-chatoptions-duplicate
branch
from
711220d to
babf8c7
Compare
Signed-off-by: guanxu <1510424541@qq.com>
Signed-off-by: guanxu <1510424541@qq.com>
Contributor
Author
|
@sdeleuze I have fixed the unit tests and add some code clean up, please take a look when you are free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.