Remove internal tool execution from OpenAiChatModel#6257
Closed
stohirov wants to merge 1 commit into
Closed
Conversation
9 tasks
Part of spring-projects#6251 Signed-off-by: stohirov <suxrobtoxirov001@gmail.com> # Conflicts: # auto-configurations/models/spring-ai-autoconfigure-model-openai/src/main/java/org/springframework/ai/model/openai/autoconfigure/OpenAiChatAutoConfiguration.java # models/spring-ai-openai/src/main/java/org/springframework/ai/openai/OpenAiChatModel.java
stohirov
force-pushed
the
remove-internal-tool-execution-openai
branch
from
3bad551 to
820cf49
Compare
Contributor
Author
|
@sdeleuze I have a question: currently, while calling the builder().toolCallingManager(toolCallingManager) as it is tagged as deprecated, the build is failing. Should I implement updates that will remove toolCallingManager and use different tool or any other way to work around it? (SurpessWarnings("deprecation") It is not just OpenAI but in other places as well. Any feedbacks? I guess you can just run ./mvnw test-compile from origin/main and it should happen automatically |
Contributor
|
rebased, fix tests and squashed at 85db88a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6251
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
git commit -s) per the DCOmainbranch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!