Move advisors to their proper modules#6309
Merged
Merged
Conversation
ilayaperumalg
approved these changes
Jun 5, 2026
ThomasVitale
reviewed
Jun 5, 2026
To be consistent with other module and conventions. See spring-projects#6309 Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
added a commit
to sdeleuze/spring-ai
that referenced
this pull request
Jun 5, 2026
…module Its package also changes from org.springframework.ai.tool.toolsearch.advisor to org.springframework.ai.chat.client.advisor.toolsearch. Closes spring-projects#6309 Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
added a commit
to sdeleuze/spring-ai
that referenced
this pull request
Jun 5, 2026
This commit moves TOOL_SEARCH_TOOL_SESSION_ID_KEY from ToolSearchToolCallingAdvisor to ToolSearchTool to avoid a circular dependency issue. Its package also changes from org.springframework.ai.tool.toolsearch.advisor to org.springframework.ai.chat.client.advisor.toolsearch. Closes spring-projects#6309 Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
force-pushed
the
advisors-refactoring
branch
from
b5722c8 to
1254c54
Compare
This commit moves TOOL_SEARCH_TOOL_SESSION_ID_KEY from ToolSearchToolCallingAdvisor to ToolSearchTool to avoid a circular dependency issue. Its package also changes from org.springframework.ai.tool.toolsearch.advisor to org.springframework.ai.chat.client.advisor.toolsearch. Closes spring-projects#6309 Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
force-pushed
the
advisors-refactoring
branch
from
1254c54 to
d1df0ae
Compare
tzolov
approved these changes
Jun 5, 2026
sdeleuze
added a commit
that referenced
this pull request
Jun 5, 2026
To be consistent with other module and conventions. See #6309 Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spring-ai-advisors-vector-storetospring-ai-vector-store-advisorToolSearchToolCallingAdvisorto aspring-ai-tool-search-advisormodule