Fix strict mode payload placement in OpenAiChatModel#6540
Open
prachipanditrao wants to merge 1 commit into
Open
Fix strict mode payload placement in OpenAiChatModel#6540prachipanditrao wants to merge 1 commit into
OpenAiChatModel#6540prachipanditrao wants to merge 1 commit into
Conversation
This commit moves the 'strict' parameter from the JSON-Schema parameters object to the function level within the FunctionDefinition builder, aligning with the official OpenAI/Azure API specification. It also exposes a strict configuration flag in OpenAiChatOptions. Fixes spring-projects#6536 Signed-off-by: prachipanditrao <prachi.panditrao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the tool calling defect where the
strictconfiguration property was incorrectly serialized inside the JSON-Schema parameters object rather than at the function-level wrapper, causing it to act as a silent no-op.It moves the property mapping to the
FunctionDefinitionbuilder block withinOpenAiChatModelto align with the official OpenAI/Azure API specifications and exposes a strict configuration flag inOpenAiChatOptions.Fixes #6536