Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionContext.isDirty() is not very accurate [BATCH-1566] #2020

Closed
spring-issuemaster opened this issue May 12, 2010 · 2 comments
Closed

ExecutionContext.isDirty() is not very accurate [BATCH-1566] #2020

spring-issuemaster opened this issue May 12, 2010 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented May 12, 2010

Dave Syer opened BATCH-1566 and commented

A context is only dirty if a new value is put or an old one is removed, but the implementation sets dirty on all puts.


Referenced from: commits 963142c

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jun 23, 2010

Dave Syer commented

Fixed with check involving comparing the result of map.put/remove with the value passed in.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 4, 2013

Chris French commented

Should the fix check if the flag is already dirty as well before setting it to false in cases where the put is the same value as exists? If the isDirty flag is already true shouldn't it remain dirty/true? I just noticed this in the SimpleStepExecutionSplitter where the isDirty flag on restart is false. In our case the previous execution failed in the partition method so the partition method needs to be called again to set the contexts up. Seems like this dirty flag is the culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.