Skip to content

Conversation

@kanathan9
Copy link

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

@fmbenhassine
Copy link
Contributor

fmbenhassine commented Oct 10, 2024

Thank you for this PR, @kanathan9 ! The changes look good to me 👍 However, this PR removes the APIs related to LobHandler, not just deprecate them as planned in #4588. We do not remove public APIs in minor versions, so I will plan this PR for v6. I will take care of the deprecation myself for the upcoming 5.2.0-M2.

@fmbenhassine fmbenhassine added this to the 6.0.0 milestone Oct 10, 2024
@fmbenhassine fmbenhassine changed the title #4588 Deprecate LobHandler Remove deprecations of LobHandler Oct 10, 2024
@kanathan9
Copy link
Author

Thank you for the feedback! 🙏 I appreciate the clarification regarding the LobHandler APIs.

@fmbenhassine
Copy link
Contributor

Hi @kanathan9

I unintentionally removed the deprecations related to LobHandler as part of #4819. I forgot about this PR, apologies for that. I was in a flow state working in batch mode 😄

I appreciate your time and effort anyway. Thank you.

@fmbenhassine fmbenhassine removed this from the 6.0.0 milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants