Fix silent data loss in ChunkOrientedStep when skip policy rejects #5081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retry is exhausted and skipPolicy.shouldSkip() returns false, ChunkOrientedStep should fail the job instead of silently discarding the item. This change adds proper exception handling to prevent silent data loss. - Add NonSkippableReadException in doSkipInRead() else block - Add NonSkippableProcessException in doSkipInProcess() else block - Add NonSkippableWriteException in scan() else block - Add test case for skip policy rejection scenario Fixes spring-projectsgh-5079 Signed-off-by: kjg <kimjg2477@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds proper exception handling in ChunkOrientedStep to prevent silent data loss when skip policy rejects skipping after retry exhaustion.
Changes:
Problem:
When retry is exhausted and skipPolicy.shouldSkip() returns false, the current implementation silently discards items without throwing an exception. This causes silent data loss.
Solution:
Added else blocks to throw NonSkippableReadException, NonSkippableProcessException, or NonSkippableWriteException when skip policy rejects skipping.
Fixes gh-5079