GH-5295: Fix parameter value truncation in CommandLineJobOperator#5296
Open
Wordbe wants to merge 1 commit intospring-projects:mainfrom
Open
GH-5295: Fix parameter value truncation in CommandLineJobOperator#5296Wordbe wants to merge 1 commit intospring-projects:mainfrom
Wordbe wants to merge 1 commit intospring-projects:mainfrom
Conversation
…JobOperator
CommandLineJobOperator.parse() uses String.split("=") which splits on
every "=" character, causing parameter values containing "=" to be
truncated. Additionally, parameters without "=" cause an
ArrayIndexOutOfBoundsException.
Use StringUtils.splitArrayElementsIntoProperties for consistency with
JobLauncherApplicationRunner and the deprecated CommandLineJobRunner.
Signed-off-by: Wordbe <seonghojin3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommandLineJobOperator.parse()usesString.split("=")without a limit, which splits on every=character. This truncates parameter values that contain=(e.g. URLs with query strings) and throwsArrayIndexOutOfBoundsExceptionfor parameters without=.Replaced with
StringUtils.splitArrayElementsIntoProperties, consistent withJobLauncherApplicationRunnerand the deprecatedCommandLineJobRunner.Resolves #5295