Fix duplicated write count in local chunking sample#5309
Closed
answndud wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix duplicated write count in local chunking sample#5309answndud wants to merge 1 commit intospring-projects:mainfrom
answndud wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: MJY <jmoon0227@gmail.com>
answndud
force-pushed
the
fix/local-chunking-write-count-5302
branch
from
565a03d to
4c6fc9a
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contribution.incrementWriteCount(chunk.size())fromLocalChunkingJobConfigurationChunkOrientedStepLocalChunkingJobFunctionalTests(success/failure paths)Why
ChunkOrientedStep#writeChunkalready increments write count after a successful write. The sample also incremented it manually, which made the reported write count misleading.Closes #5302