Fail TaskletStep on checked exceptions in non-rollback mode#5316
Open
answndud wants to merge 1 commit intospring-projects:mainfrom
Open
Fail TaskletStep on checked exceptions in non-rollback mode#5316answndud wants to merge 1 commit intospring-projects:mainfrom
answndud wants to merge 1 commit intospring-projects:mainfrom
Conversation
Do not swallow checked exceptions when rollbackOn returns false. Add a regression test for PROPAGATION_NOT_SUPPORTED to ensure the step fails instead of re-executing indefinitely. Signed-off-by: MJY <jmoon0227@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tasklet.executeeven whentransactionAttribute.rollbackOn(e)returnsfalseROLLBACK_EXCEPTION_KEYand rollback count) when rollback is actually configured for the exceptionPROPAGATION_NOT_SUPPORTEDto ensure a checked exception fails the step instead of being silently retriedWhy
With
TaskletStepand a transaction attribute likePROPAGATION_NOT_SUPPORTED, a checked exception can be swallowed when rollback is disabled for that exception type. This causes the step loop to continue and re-execute the tasklet instead of failing.Closes #5292
Testing
./mvnw -Dmaven.user.home=/tmp/m2 -pl spring-batch-core -Dtest=org.springframework.batch.core.step.item.TaskletStepExceptionTests test