Gradle plugin doesn't package org.apache.activemq.protobuf:activemq-protobuf:1.1

[wilkinsona]

This question on Stack Overflow appears to be a bug. The problem can be reproduced with this build.gradle:

buildscript {
    repositories {
        maven { url "http://repo.spring.io/libs-snapshot" }
    }
    dependencies {
        classpath("org.springframework.boot:spring-boot-gradle-plugin:1.0.0.RC4")
    }
}

apply plugin: 'java'
apply plugin: 'spring-boot'

repositories {
    mavenCentral()
}

dependencies {
    compile('org.apache.activemq:activemq-client:5.9.0')
    compile('org.apache.activemq:activemq-broker:5.9.0')
    compile('org.apache.activemq:activemq-kahadb-store:5.9.0')
    compile('org.apache.activemq.protobuf:activemq-protobuf:1.1')
}

task wrapper(type: Wrapper) {
    gradleVersion = '1.11'
}

As reported on SO, the activemq-protobuf dependency is missing:

./gradlew clean build && unzip -l build/libs/gradle-test.jar | grep activemq
:clean
:compileJava
:processResources UP-TO-DATE
:classes
:jar
:bootRepackage
:assemble
:compileTestJava UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test UP-TO-DATE
:check UP-TO-DATE
:build

BUILD SUCCESSFUL

Total time: 6.418 secs
  1165912  03-13-14 17:13   lib/activemq-client-5.9.0.jar
  1002495  03-13-14 17:13   lib/activemq-broker-5.9.0.jar
   539427  03-13-14 17:13   lib/activemq-kahadb-store-5.9.0.jar
   685801  03-13-14 17:13   lib/activemq-openwire-legacy-5.9.0.jar

[wilkinsona]

Gradle correctly identifies activemq-protobuf's type as being maven-plugin. This isn't one of the types supported by ProjectLibraries so it's excluded from the repackaged archive.

So, the question is, should the Gradle plugin include artifacts that are Maven plugins? The Gradle plugin's behaviour should match the Maven plugin's behaviour, i.e. the Maven plugin may have the same problem.

[dsyer]

I guess the real question is "why is it a plugin?" Seems like it might be a problem for the author of that library, but I don't see any reason not to include plugins in our jars if the user says they are a dependency.

[philwebb]

As long as plugin files are still jars I don't think we will have a problem. We need to make sure that non-jar files don't sneak back in (see #324).