Adding missing libraries to dependencies pom#10338
Closed
nicolaferraro wants to merge 1 commit intospring-projects:masterfrom
Closed
Adding missing libraries to dependencies pom#10338nicolaferraro wants to merge 1 commit intospring-projects:masterfrom
nicolaferraro wants to merge 1 commit intospring-projects:masterfrom
Conversation
|
@nicolaferraro Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@nicolaferraro Thank you for signing the Contributor License Agreement! |
Member
|
Thanks for the PR. I'd like to split this into a separate issue/pull request for each affected library:
Could you do that please? |
wilkinsona
added
the
status: waiting-for-feedback
Member
wilkinsona
added
status: declined
Author
|
Sorry, I missed that. I'll create specific PRs for the issues you've just opened. |
Author
|
Ok, I've seen they have been implemented. No more work to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working on the alignment of Apache Camel with Spring-Boot 2 (CAMEL-11756) and we found some missing dependencies in the spring-boot dependencies pom that causes problems with Camel transitive dependencies.
E.g. spring-boot-dependencies forces version X metrics-core. One of our module is compiled with version Y of metrics-core and metrics-json, but it can work also with version X (we have integration tests to ensure it).
But when the user creates an application with our module, he gets version X of metrics-core, and version Y of metrics-json, because the spring-boot-dependencies pom does not include metrics-json in the dependencyManagement section. The same happens with other libraries.
We are trying to make sure that next versions of Camel support multiple versions of spring-boot, so we cannot keep these versions in our side. Spring-boot dependencies should be complete.
The 1.5.x branch would also benefit from this change.