Corrected documentation about the RemoteIpValve #1989
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to step debug the RemoteIpValve to see why the IP-address was not resolved
wilkinsona
pushed a commit
that referenced
this pull request
Nov 25, 2014
In a properties file, a backslash is used as an escape character for the line terminator sequence to allow values to be split across multiple lines. When a backslash is used elsewhere they're stripped out of the property's value. This commit updates .properties-based examples for configuring server.tomcat.internal-proxies to escape the backslahes so that they are retained in the property's value at runtime. See gh-1989
wilkinsona
added a commit
that referenced
this pull request
Nov 25, 2014
Member
|
Merged. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to step-debug the RemoveIpValve class to figure out why the IP-address was not correctly picked up from the X-Forwarded-For header. Seems the example documentation is incorrect...