Skip to content

Conversation

@abhishek-abhi
Copy link

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 29, 2020
@wilkinsona
Copy link
Member

wilkinsona commented Jul 29, 2020

Thanks for the proposal, but there's no need for the map to be a ConcurrentHashMap as it is never mutated. This is guaranteed by AuditEvent creating an unmodifiable map.

This is the fourth pull request of this kind that you've created today and, unfortunately, we've had to decline them all. I'm sure that's frustrating for you and it's also time-consuming for us and everyone watching the repository. As @snicoll said, if you'd like to chat about things, please come and do that on Gitter first. That way we can hopefully avoid the overhead of creating a pull request that we won't want to merge.

@wilkinsona wilkinsona closed this Jul 29, 2020
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants