Skip to content

Conversation

@abhishek-abhi
Copy link

No description provided.

@abhishek-abhi
Copy link
Author

Hi, @sbrannen please review my PR and kindly merge if it is okay.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 7, 2020
@snicoll
Copy link
Member

snicoll commented Aug 9, 2020

@abhishek-abhi the class is abstract so there is no need to add a private constructor there.

As we've mentioned to you in the Spring Boot project, if you're trying to contribute, please find an existing issue or ask questions before starting.

@snicoll snicoll closed this Aug 9, 2020
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants