Skip to content

Fix Bug #26894#27542

Closed
crystalcd wants to merge 1 commit intospring-projects:2.4.xfrom
crystalcd:2.4.x
Closed

Fix Bug #26894#27542
crystalcd wants to merge 1 commit intospring-projects:2.4.xfrom
crystalcd:2.4.x

Conversation

@crystalcd
Copy link
Copy Markdown

If the main class throws an exception,When RestartLauncher run it will throw a InvocationTargetException,So I'm going to ignore it.
Fixes #26894

@pivotal-cla
Copy link
Copy Markdown

@crystalcd Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link
Copy Markdown

@crystalcd Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 2, 2021
@wilkinsona
Copy link
Copy Markdown
Member

Thanks for the proposal. Unfortunately, ignoring the exception isn't the right thing to do. The intention is that a restart that fails due to an application context refresh failure will be retried once the user has made a change to the application. This retry is triggered by FileWatchingFailureHandler.handle(Throwable). If the InvocationTargetException is ignored entirely, an application using Devtools won't recover from a restart failure caused by an application context refresh failure and the JVM will exit instead.

@wilkinsona wilkinsona closed this Aug 9, 2021
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants