Undertow enable request wrappers #4275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about changing this by default. As explained in my comment on spring-cloud-netflix#582, Undertow will, by default, quite happily allow a request to be wrapped, as long as it's wrapped with |
|
I am not either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a small request related to spring-cloud/spring-cloud-netflix#582 and spring-cloud/spring-cloud-netflix#524. I would like to enable by default the request wrapper in Undertow. This has a particular use case - Netflix Zuul proxy, which wraps the request/response for forwarding. Other cases probably include url rewriting and similar solutions. This setting is required to disable Undertow checks that are very selective and does not manifest themselves in every situation, but generally break the exception propagation. Enabling that in Spring Cloud directly would unnecessary couple the code with particular container so I though it would be better to directly do this here.