Fix progress calculation using proper Integer unboxing method#44713
Closed
KmYgJn wants to merge 10 commits intospring-projects:mainfrom
Closed
Fix progress calculation using proper Integer unboxing method#44713KmYgJn wants to merge 10 commits intospring-projects:mainfrom
KmYgJn wants to merge 10 commits intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
nosan
reviewed
Mar 14, 2025
|
|
||
| int getProgress() { | ||
| return withinPercentageBounds((this.progressByStatus.values().stream().mapToInt(Integer::valueOf).sum()) | ||
| return withinPercentageBounds((this.progressByStatus.values().stream().mapToInt(Integer::intValue).sum()) |
Contributor
There was a problem hiding this comment.
In that case .reduce(0, Integer::sum) can be used instead of mapToInt(..).sum()
Contributor
There was a problem hiding this comment.
I think .mapToInt(...).sum() makes it easier to understand.
Contributor
|
Hello @KmYgJn, please sign your commit, so that the DCO check passes. See this blog post for more details. Thanks! |
mhalbritter
added
the
status: waiting-for-feedback
See spring-projectsgh-44033 Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
This reverts commit d98dd7b. Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
This reverts commit 105dfb8. Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
This reverts commit dad936d. Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
Signed-off-by: youngjin_dev <qazkyj0310@gmail.com>
KmYgJn
force-pushed
the
optimize-progress-calculation
branch
from
79dd1e0 to
179c5da
Compare
Contributor
Author
|
Close the PR to get a clean PR again |
bclozel
added
status: invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Integer conversion in the
getProgress()method by replacingInteger::valueOfwithInteger::intValue. The original code incorrectly usedvalueOfwhich is meant for converting other types to Integer objects, whileintValue()is the correct method for unboxing Integer objects to primitive int values.Changes
getProgress()method in the progress calculation logicInteger::valueOfwithInteger::intValuefor proper unboxingReasoning
progressByStatus.values()returns a collection of Integer objects. When processing these values withmapToInt(), we need to extract the primitive int value from each Integer object. ThevalueOf()method is meant for creating Integer objects from other types (like String), whileintValue()is designed for extracting the primitive value from an Integer object.