Skip to content

Make the logger logger private static final #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kirill-vlasov wants to merge 1 commit into from
Closed

Make the logger logger private static final #4784

kirill-vlasov wants to merge 1 commit into from

Conversation

@kirill-vlasov
Copy link
Contributor

@kirill-vlasov kirill-vlasov commented Dec 16, 2015

This pull request is focused on resolving occurrences of Sonar rule squid:S1312 - Loggers should be "private static final" and should share a naming convention

You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1312

Please let me know if you have any questions.

Kirill Vlasov

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 16, 2015
@wilkinsona
Copy link
Member

wilkinsona commented Dec 16, 2015

Thanks for the PR. Have you signed the CLA?

@kirill-vlasov
Copy link
Contributor Author

kirill-vlasov commented Dec 16, 2015

Yes, I have signed right after creating pull request

@philwebb philwebb removed the status: waiting-for-triage An issue we've not yet triaged label Dec 16, 2015
@philwebb philwebb self-assigned this Dec 16, 2015
@philwebb philwebb added this to the 1.3.1 milestone Dec 16, 2015
@philwebb philwebb closed this in ec2f33f Dec 16, 2015
philwebb added a commit that referenced this pull request Dec 16, 2015
@philwebb
Merge pull request #4784 from kirill-vlasov
4bdb2d3 
* pr/4784:
  Make loggers private static final
wilkinsona added a commit that referenced this pull request Jan 13, 2016
@wilkinsona
Complete static final logger changes that were started in ec2f33f
27a81e1 
This commit completes the changes to consistently used static final
fields for Log instances that were started in ec2f33f. Specifically it:

 - Removes this. when accessing logger fields that are now static
 - Renames some fields from log to logger
 - Makes some logger fields static

See gh-4784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@philwebb philwebb

Labels

None yet

Projects

None yet

Milestone

1.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@kirill-vlasov @wilkinsona @philwebb @spring-projects-issues