Skip to content

Deprecate Derby support #48590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marschall wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Deprecate Derby support #48590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions module/spring-boot-jdbc/src/main/java/org/springframework/boot/jdbc/DatabaseDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ public enum DatabaseDriver {

/**
* Apache Derby.
* @deprecated Derby is retired, use HSQLDB or H2
Copy link
Member

@snicoll snicoll Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the other deprecation in the codebase, we use a standard format for this.

*/
@Deprecated(forRemoval = true, since = "4.1")
Copy link
Member

@snicoll snicoll Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 4.1.0

DERBY("Apache Derby", "org.apache.derby.jdbc.EmbeddedDriver", "org.apache.derby.jdbc.EmbeddedXADataSource",
"SELECT 1 FROM SYSIBM.SYSDUMMY1"),

Expand Down
6 changes: 6 additions & 0 deletions ...ing-boot-jdbc/src/main/java/org/springframework/boot/jdbc/EmbeddedDatabaseConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ public enum EmbeddedDatabaseConnection {

/**
* Derby Database Connection.
* @deprecated Derby is retired, use HSQLDB or H2
*/
@Deprecated(forRemoval = true, since = "4.1")
DERBY("jdbc:derby:memory:%s;create=true"),

/**
Expand All @@ -83,6 +85,7 @@ public enum EmbeddedDatabaseConnection {
* Returns the driver class name.
* @return the driver class name
*/
@SuppressWarnings("removal")
public @Nullable String getDriverClassName() {
// See https://github.com/spring-projects/spring-boot/issues/32865
return switch (this) {
Expand All @@ -97,6 +100,7 @@ public enum EmbeddedDatabaseConnection {
* Returns the {@link EmbeddedDatabaseType} for the connection.
* @return the database type
*/
@SuppressWarnings("removal")
public @Nullable EmbeddedDatabaseType getType() {
// See https://github.com/spring-projects/spring-boot/issues/32865
return switch (this) {
Expand All @@ -117,6 +121,7 @@ public enum EmbeddedDatabaseConnection {
return (this.url != null) ? String.format(this.url, databaseName) : null;
}

@SuppressWarnings("removal")
boolean isEmbeddedUrl(String url) {
// See https://github.com/spring-projects/spring-boot/issues/32865
return switch (this) {
Expand Down Expand Up @@ -151,6 +156,7 @@ public static boolean isEmbedded(@Nullable String driverClass, @Nullable String
return (url == null || connection.isEmbeddedUrl(url));
}

@SuppressWarnings("removal")
private static EmbeddedDatabaseConnection getEmbeddedDatabaseConnection(String driverClass) {
return Stream.of(H2, HSQLDB, DERBY)
.filter((connection) -> connection.isDriverCompatible(driverClass))
Expand Down
2 changes: 2 additions & 0 deletions module/spring-boot-jdbc/src/test/java/org/springframework/boot/jdbc/DatabaseDriverTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ void unknownOnNullProductName() {
}

@Test
@SuppressWarnings("removal")
Copy link
Member

@snicoll snicoll Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should flag the test as deprecated instead;

void databaseProductNameLookups() {
assertThat(DatabaseDriver.fromProductName("newone")).isEqualTo(DatabaseDriver.UNKNOWN);
assertThat(DatabaseDriver.fromProductName("Apache Derby")).isEqualTo(DatabaseDriver.DERBY);
Expand Down Expand Up @@ -88,6 +89,7 @@ void databaseProductNameLookups() {
}

@Test
@SuppressWarnings("removal")
void databaseJdbcUrlLookups() {
assertThat(DatabaseDriver.fromJdbcUrl("jdbc:newone://localhost")).isEqualTo(DatabaseDriver.UNKNOWN);
assertThat(DatabaseDriver.fromJdbcUrl("jdbc:derby:sample")).isEqualTo(DatabaseDriver.DERBY);
Expand Down
2 changes: 2 additions & 0 deletions ...oot-jdbc/src/test/java/org/springframework/boot/jdbc/EmbeddedDatabaseConnectionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ void h2CustomDatabaseName() {
}

@Test
@SuppressWarnings("removal")
void derbyCustomDatabaseName() {
assertThat(EmbeddedDatabaseConnection.DERBY.getUrl("myderbydb"))
.isEqualTo("jdbc:derby:memory:myderbydb;create=true");
Expand Down Expand Up @@ -80,6 +81,7 @@ void isEmbeddedWithDriverAndUrl(String driverClassName, String url, boolean embe
assertThat(EmbeddedDatabaseConnection.isEmbedded(driverClassName, url)).isEqualTo(embedded);
}

@SuppressWarnings("removal")
static Object[] embeddedDriverAndUrlParameters() {
return new Object[] {
new Object[] { EmbeddedDatabaseConnection.H2.getDriverClassName(), "jdbc:h2:~/test", false },
Expand Down