ThreadPoolTaskScheduleBuilder unnecessarily loses precision when configuring await termination time#50225
Merged
snicoll merged 2 commits intospring-projects:3.5.xfrom Apr 28, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thank you for the PR, @ares333. Can you please update the tests to verify that the millisecond precision is retained? Perhaps by modifying the existing |
wilkinsona
added
the
status: waiting-for-feedback
Contributor
Author
|
updated the test to use Duration.ofMillis() and verified that the millisecond precision is retained. |
spring-projects-issues
added
status: feedback-provided
wilkinsona
changed the title
wilkinsona
added
type: bug
quaff
added a commit
to quaff/spring-framework
that referenced
this pull request
Apr 28, 2026
…illis We should encourage using milliseconds over seconds for better precision, see spring-projects/spring-boot#50225 Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
This commit fixes ThreadPoolTaskExecutorBuilder#awaitTerminationPeriod so that it does not lose millisecond precision. See spring-projectsgh-50225 Signed-off-by: Ares <ares333@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadPoolTaskSchedulerBuilder.awaitTerminationPeriod lost millisecond information and fix it.