Provide smoother usage of Observabilty. #1322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttddyy
reviewed
Oct 21, 2022
Comment on lines
65
to
72
| CommandLineRunner initData(EmployeeRepository repository, ObservationRegistry registry) { // <1> | ||
| Observation observation = Observation.start("init-database", registry); // <2> | ||
| try (Observation.Scope scope = observation.openScope()) { // <3> | ||
| return args -> { | ||
| repository.save(new Employee("1", "Frodo", "ring bearer")); | ||
| repository.save(new Employee("2", "Bilbo", "burglar")); | ||
| }; | ||
| } catch (Exception e) { | ||
| observation.error(e); // <4> | ||
| throw e; | ||
| } finally { | ||
| observation.stop(); // <5> | ||
| } | ||
| } |
There was a problem hiding this comment.
I think wrapping inside of the lambda is more appropriate to capture the observation for this operations.
CommandLineRunner initData(EmployeeRepository repository, ObservationRegistry registry) { // <1>
return args -> {
Observation observation = Observation.start("init-database", registry); // <2>
try (Observation.Scope scope = observation.openScope()) { // <3>
repository.save(new Employee("1", "Frodo", "ring bearer"));
repository.save(new Employee("2", "Bilbo", "burglar"));
} catch (Exception e) {
observation.error(e); // <4>
throw e;
} finally {
observation.stop(); // <5>
}
};
Contributor
There was a problem hiding this comment.
BTW why not just call Observation.createNotStarted("init-database"), registry).observe(() -> { repository.save(.....); } ?
…Cassandra. Resolves #1321.
gregturn
force-pushed
the
issue/gh-1321
branch
from
333fdab to
ae6303f
Compare
Member
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @marcingrzejszczak
This one is MUCH easier to use. I also updated the documentation to illustrate its usage.