AbstractMappingContext.getPersistentEntity: Order of strict checking and shouldCreatePersistentEntity is wrong [DATACMNS-447]

[spring-projects-issues]

Michael Hunger opened DATACMNS-447 and commented

The current order makes the persistent entity creation fail in strict mode even if the requested type is one that is filtered out in shouldCreatePersistentEntity() (e.g. simple java types, collections etc).

I want to make the mapping context strict in Spring Data Neo4j as for correct index creation the entities have to be known upfront and so base-package for <neo4j:config/> is mandatory now. The strict mode should enforce this.

---

Reference URL: jexp@50fdcd5?w=1

Referenced from: pull request #71

Backported to: 1.7.1 (Codd SR1)

[spring-projects-issues]

Thomas Darimont commented

Integrated &polished Michael's commit into the PR

[spring-projects-issues]

Thomas Darimont commented

Please review

[spring-projects-issues]

Thomas Darimont commented

I reduced this PR to only contain the changed ordering of the checks in AbstractMappingContext.getPersistentEntity(TypeInformation)