DATACMNS-534 - Add reading / writing property information to PersistentProperty. #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntProperty. Prepare issue branch.
…ntProperty. We introduced optional annotations for @ReadingProperty and @WritingProperty which can be used for marking properties for being persisted to or only read from the store. Both annotations can be used as meta-annotations for building special ones like eg. @score in Spring Data Mongodb. Having none of these annotations used will behave as if both annotations where present. This means that @ReadingProperty @WritingProperty String foo; is will return the same for property.isReading() and property.isWriting() as plain String foo; Both annotations are superseded by @transient which will force isReading() and isWriting() to false;
Member
|
I actually thought we decided to go with the less sophisticated variant for now:
That should make the changes a bit smaller. Is that still sufficient for the use case in the Solr module? |
…ntProperty. We introduced @ReadOnlyProperty which can be used for excluding properties from being persisted. @transient supersedes @ReadOnlyProperty. @ReadOnlyProperty can be used as meta-annotation for others like @TextScore in spring data mongodb.
christophstrobl
added a commit
that referenced
this pull request
Jul 9, 2014
This commit introduces @ReadOnlyProperty to mark properties as not to be persisted. That trait is exposed via the newly added PersistentProperty.isWritable() which supersedes shallBePersisted(). Currently all non-transient property that are not annotated with @ReadOnlyProperty are considered writable. Original pull request: #88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced
@ReadOnlyPropertywhich can be used for excluding properties from being persisted. TheAnnotationBasedPersistentProperty.isReadOnly()will returntruein that case, whilePersistentProperty.shallBePersisted()returnsfalse.@Transientsupersedes@ReadOnlyProperty.@ReadOnlyPropertycan be used as meta-annotation for others like@TextScorein spring data mongodb.