Jackson 3.x GeoJson (de-)serializers #5102
Conversation
Adds a GeoJsonJackson3Module. Closes #5100
| * | ||
| * @author Jens Schauder | ||
| */ | ||
| public class GeoJsonJackson3Configuration implements SpringDataJackson3Modules { |
There was a problem hiding this comment.
Given the opportunity I think we should align the naming our newly added GeoJson Jackson3 support to follow what is outlined in spring-projects/spring-data-redis#3219
|
|
||
| public class GeoJsonJackson3Module { | ||
|
|
||
| private static Version version = new Version(3, 2, 0, null, "org.springframework.data", |
There was a problem hiding this comment.
version should be updated
| @ContextConfiguration | ||
| public class GeoJsonConfigurationIntegrationTests { | ||
| public class GeoJsonJackson3ConfigurationIntegrationTests { | ||
|
|
||
| @Configuration | ||
| @EnableSpringDataWebSupport | ||
| static class Config {} | ||
|
|
||
| @Autowired GeoJsonModule geoJsonModule; | ||
| @Autowired | ||
| GeoJsonJackson3Module geoJsonModule; | ||
|
|
||
| @Test // DATAMONGO-1181 | ||
| @Test // GH-5100 | ||
| public void picksUpGeoJsonModuleConfigurationByDefault() { | ||
| assertThat(geoJsonModule).isNotNull(); | ||
| } |
There was a problem hiding this comment.
Please do not remove the the wiring of the old module since it is still present and should be picked up in case Jackson2 is present. SpringDataWebConfigurationImportSelector will pick and choose based on what's present.
It should still be possible to wire the old one.
| * @author Bjorn Harvold | ||
| * @author Jens Schauder | ||
| */ | ||
| @RunWith(SpringRunner.class) |
There was a problem hiding this comment.
we might want to move to junit jupiter here
|
@schauder mind naming (initial) branches for existing issues following the established pattern without adding any extra |
Adds a GeoJsonJackson3Module.
Closes #5100