Use domainClass as driver for the root node name. #2341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
requested changes
Jul 26, 2021
| @API(status = Status.EXPERIMENTAL, since = "6.0") | ||
| public final class Constants { | ||
|
|
||
| public static final SymbolicName NAME_OF_ROOT_NODE = Cypher.name("n"); |
Collaborator
There was a problem hiding this comment.
I would do a NAME_OF_TYPED_ROOT_NODE.apply(null) and assigned that, so that it is somewhat compatible in case anyone used those constants.
| */ | ||
| public class TestConstants { | ||
|
|
||
| public static final SymbolicName NAME_OF_ROOT_NODE = Cypher.name("n"); |
Collaborator
There was a problem hiding this comment.
that whole class can go away if you agree with me on the first suggestion.
meistermeier
added a commit
that referenced
this pull request
Jul 26, 2021
Original pull request: #2341
Collaborator
Author
|
Merged with 44185a4 |
meistermeier
added a commit
that referenced
this pull request
Sep 29, 2021
Not working if there is no relationship.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.