Skip to content

Repro intermittent order change in saveAll #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Repro intermittent order change in saveAll #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions .../springframework/data/r2dbc/repository/support/SimpleR2dbcRepositoryIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public class SimpleR2dbcRepositoryIntegrationTests extends R2dbcIntegrationTestS

@Before
public void before() {

Hooks.onOperatorDebug();

this.connectionFactory = createConnectionFactory();
Expand Down Expand Up @@ -122,29 +121,39 @@ public void shouldSaveObjectsUsingIterable() {

LegoSet legoSet1 = new LegoSet(null, "SCHAUFELRADBAGGER", 12);
LegoSet legoSet2 = new LegoSet(null, "FORSCHUNGSSCHIFF", 13);
LegoSet legoSet3 = new LegoSet(null, "RALLYEAUTO", 14);
LegoSet legoSet4 = new LegoSet(null, "VOLTRON", 15);

repository.saveAll(Arrays.asList(legoSet1, legoSet2)) //
repository.saveAll(Arrays.asList(legoSet1, legoSet2, legoSet3, legoSet4)) //
.as(StepVerifier::create) //
.expectNextCount(2) //
.consumeNextWith(legoSet -> assertThat(legoSet.manual).isEqualTo(12)) //
.consumeNextWith(legoSet -> assertThat(legoSet.manual).isEqualTo(13)) //
.consumeNextWith(legoSet -> assertThat(legoSet.manual).isEqualTo(14)) //
.consumeNextWith(legoSet -> assertThat(legoSet.manual).isEqualTo(15)) //
.verifyComplete();

Map<String, Object> map = jdbc.queryForMap("SELECT COUNT(*) FROM repo_legoset");
assertThat(map).containsEntry("count", 2L);
assertThat(map).containsEntry("count", 4L);
}

@Test
public void shouldSaveObjectsUsingPublisher() {

LegoSet legoSet1 = new LegoSet(null, "SCHAUFELRADBAGGER", 12);
LegoSet legoSet2 = new LegoSet(null, "FORSCHUNGSSCHIFF", 13);
LegoSet legoSet3 = new LegoSet(null, "RALLYEAUTO", 14);
LegoSet legoSet4 = new LegoSet(null, "VOLTRON", 15);

repository.saveAll(Flux.just(legoSet1, legoSet2)) //
repository.saveAll(Flux.just(legoSet1, legoSet2, legoSet3, legoSet4)) //
.as(StepVerifier::create) //
.expectNextCount(2) //
.consumeNextWith(legoSet -> assertThat(legoSet.manual).isEqualTo(12)) //
.consumeNextWith(legoSet -> assertThat(legoSet.manual).isEqualTo(13)) //
.consumeNextWith(legoSet -> assertThat(legoSet.manual).isEqualTo(14)) //
.consumeNextWith(legoSet -> assertThat(legoSet.manual).isEqualTo(15)) //
.verifyComplete();

Map<String, Object> map = jdbc.queryForMap("SELECT COUNT(*) FROM repo_legoset");
assertThat(map).containsEntry("count", 2L);
assertThat(map).containsEntry("count", 4L);
}

@Test
Expand Down