Skip to content

DATAREDIS-729 - ZLEXCOUNT command #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anshlykov wants to merge 3 commits into from
Closed

DATAREDIS-729 - ZLEXCOUNT command #569

anshlykov wants to merge 3 commits into from

Conversation

@anshlykov
Copy link
Contributor

@anshlykov anshlykov commented Oct 9, 2020

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

This PR adds support for the ZLEXCOUNT command.

@anshlykov anshlykov marked this pull request as draft October 13, 2020 13:15
@mp911de
Copy link
Member

mp911de commented Oct 13, 2020

We can include this PR for tomorrow's release if we can get it into a merge-able state within the next hour or so.

@anshlykov
Merge remote-tracking branch 'upstream/master' into issue/DATAREDIS-7…
0539934 
…29-ZLEXCOUNT

# Conflicts:
#	src/main/java/org/springframework/data/redis/connection/RedisZSetCommands.java
#	src/main/java/org/springframework/data/redis/connection/StringRedisConnection.java
#	src/main/java/org/springframework/data/redis/connection/jedis/JedisZSetCommands.java
#	src/main/java/org/springframework/data/redis/connection/lettuce/LettuceZSetCommands.java
@anshlykov
DATAREDIS-729 - ZLEXCOUNT command for ZSetOperations; BoundZSetOperat…
fb538f7 
…ions; RedisZSet
@anshlykov anshlykov marked this pull request as ready for review October 13, 2020 21:38
@mp911de
Copy link
Member

mp911de commented Oct 14, 2020

Thanks a lot, going to take this PR from here.

mp911de pushed a commit that referenced this pull request Oct 14, 2020
@anshlykov @mp911de
DATAREDIS-729 - Add support for ZLEXCOUNT.
bd1332e 
Original pull request: #569.
mp911de added a commit that referenced this pull request Oct 14, 2020
@mp911de
DATAREDIS-729 - Polishing.
1964ed1 
Reorder methods so lexCount(…) comes after count(…). Tweak Javadoc wording. Simplify tests.

Original pull request: #569.
@mp911de
Copy link
Member

mp911de commented Oct 14, 2020

Thank you for your contribution and for considering adding Template API methods that makes a pretty decent pull request. That's merged and polished now.

@mp911de mp911de closed this Oct 14, 2020
@anshlykov anshlykov deleted the issue/DATAREDIS-729-ZLEXCOUNT branch October 14, 2020 08:56
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anshlykov @mp911de