-
Notifications
You must be signed in to change notification settings - Fork 378
Description
In the topmost section of the documentation of BeforeConvertCallback it is written:
The decision if the change will be an insert or update is made after this callback gets called.
This is contradictory to the points (1) and (2) in bullet points right below describing the persistence process.
Due to the fact that BeforeConvertCallback can be used to create Id values for new aggregates I think the bullet points are correct and the introductory sentence should be changed to
The decision if the change will be an insert or update is made before this callback gets called.
This would also be in line with the documentation of BeforeConvertEvent, which states:
Gets published before an aggregate gets converted into a database change, but after the decision was made if an insert or an update is to be performed.