fix flaky test in PartTreeJdbcQueryUnitTests #1096
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
Please incorporate this within #1097 |
CharlesZKQ
added a commit
to CharlesZKQ/spring-data-jdbc
that referenced
this pull request
Nov 30, 2021
…nsure the result set of conditions is the one we expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
org.springframework.data.jdbc.repository.query.PartTreeJdbcQueryUnitTests, the testcreatesQueryByEmbeddedObject()is flaky due to the non-deterministic property ofgetDeclatedFields()(please refer document). it is internally invoked bycreateQuery(). I fixed by comparing the actual generated query with two possible queries (set as expected queries), when invokinggetQuery(), it will return either one of two possible result, which eliminates the flakiness.