Skip to content

Add NOT_IN judgment to QueryMapper's convertValue function #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add NOT_IN judgment to QueryMapper's convertValue function #1745

wants to merge 3 commits into from

Conversation

@yande2011
Copy link

@yande2011 yande2011 commented Feb 29, 2024

Closes #1744

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 29, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 4, 2024
@mp911de
Copy link
Member

mp911de commented Mar 4, 2024

Care to add a few tests?

@yande2011
Copy link
Author

yande2011 commented Mar 4, 2024

Care to add a few tests?

i add an CollectionToStringConverter convert on QueryMapper, shouldMapIsNotIn cant pass on oldVersion, passed on current

@mp911de
Copy link
Member

mp911de commented Mar 4, 2024

Actually, having a test case that covers the newly introduced notIn functionality is what I was asking for.

@yande2011
Copy link
Author

yande2011 commented Mar 5, 2024

Actually, having a test case that covers the newly introduced notIn functionality is what I was asking for.

Added test cases, NotIn can also work normally with CollectionToString converter, you can review it again

@hosmanoglu
Copy link

hosmanoglu commented Mar 11, 2024

hi guys when could you merge this pr?

@schauder
Copy link
Contributor

schauder commented Mar 12, 2024

@yande2011 please provide a transcription of your name using latin characters to be used in @author tags?

@yande2011
Copy link
Author

yande2011 commented Mar 13, 2024

@yande2011 please provide a transcription of your name using latin characters to be used in @author tags?

YAN Qiang

schauder pushed a commit that referenced this pull request Mar 13, 2024
@yande2011 @schauder
Support conversion of elements in NOT_IN clause.
4a78717 
Closes #1744
Original pull request #1745
schauder added a commit that referenced this pull request Mar 13, 2024
@schauder
Polishing.
1600740 
Code formatting.
Adding author tags.
Added test for jdbc.
Fixed typo.

See #1744
Original pull request #1745
@schauder
Copy link
Contributor

schauder commented Mar 13, 2024

This is polished and merged.

@yande2011 yande2011 closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@schauder schauder

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should NOT_IN judgment be added to QueryMapper's convertValue function implementation?

5 participants

@yande2011 @mp911de @hosmanoglu @schauder @spring-projects-issues