Remove duplicate declaration of document() accessor in RowDocument
#1781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
chanhyeong
force-pushed
the
remove-duplicate-declaration-in-rowdocument
branch
from
8aeb027 to
a1f35b8
Compare
chanhyeong
force-pushed
the
remove-duplicate-declaration-in-rowdocument
branch
from
a1f35b8 to
d6b99d8
Compare
mp911de
changed the title
document() accessor in RowDocument
|
Generally, our public API goes through a deprecation cycle before we remove methods. As these are clearly duplicate methods, we can remove their variant with the current GA release. |
mp911de
added a commit
that referenced
this pull request
Apr 29, 2024
This method was never intended to be exposed (record-style accessor) as there is getDocument(). See #1781
mp911de
added a commit
that referenced
this pull request
Apr 29, 2024
Fix since version. Update Javadoc. Adjust visibility for subclassing usage. See #1781
mp911de
added a commit
that referenced
this pull request
Apr 29, 2024
Fix since version. Update Javadoc. Adjust visibility for subclassing usage. See #1781
mp911de
added
type: task
|
Thank you for your contribution. That's merged, polished, and backported now. |
mp911de
pushed a commit
that referenced
this pull request
Apr 29, 2024
mp911de
added a commit
that referenced
this pull request
Apr 29, 2024
This method was never intended to be exposed (record-style accessor) as there is getDocument(). See #1781
mp911de
added a commit
that referenced
this pull request
Apr 29, 2024
Fix since version. Update Javadoc. Adjust visibility for subclassing usage. See #1781
mp911de
pushed a commit
that referenced
this pull request
Apr 29, 2024
mp911de
added a commit
that referenced
this pull request
Apr 29, 2024
Fix since version. Update Javadoc. Adjust visibility for subclassing usage. See #1781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two method declarations of get
RowDocumentand removed the uncommented one.