Remove createPersistentEntity(..) #1783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this method with latest changes in 21e8d9a does nothing more than calling super.createPersistentEntity(..) it could be removed.
spring-projects-issues
added
the
status: waiting-for-triage
schauder
pushed a commit
that referenced
this pull request
Apr 30, 2024
createPersistentEntity(..) effectively only calls the overriden method. It therefore can be deleted. Remove error message no longer used. Original pull request #1783
schauder
pushed a commit
that referenced
this pull request
Apr 30, 2024
createPersistentEntity(..) effectively only calls the overriden method. It therefore can be deleted. Remove error message no longer used. Original pull request #1783
Contributor
|
Thanks, that's merged. |
schauder
added
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this method with latest changes in 21e8d9a does nothing more than calling super.createPersistentEntity(..) it could be removed.