Skip to content

Conversation

@mhyeon-lee
Copy link
Contributor

@mhyeon-lee mhyeon-lee commented May 3, 2020

Resolve DATAJDBC-531

@mhyeon-lee
Copy link
Contributor Author

Test failed accrossModules

includes = org.springframework.data.**
categories = sub-modules UnnamedPattern(org.springframework.data.jdbc.(*).**), UnnamedPattern(org.springframework.data.relational.(*).**), UnnamedPattern(org.springframework.data.(*).**)
output = degraph-across-modules.graphml
constraints = no cycles
} yields the following constraint violations: [sub-modules](no cycles):
    core -> repository
    repository -> core

Please provide feedback on how to resolve the dependency.
Would it be nice to remove dependency and implement the same behavior as PageableExecutionUtils?

@schauder
Copy link
Contributor

spring-projects/spring-data-commons#472 moves PageableExecutionUtils so that we can use it without creating a cycle.

@schauder schauder changed the title [DATAJDBC-531] Skip COUNT Query If Page Query result totalPage is 1. DATAJDBC-531 - Skip COUNT Query If Page Query result totalPage is 1. Oct 28, 2020
@mhyeon-lee
Copy link
Contributor Author

@schauder
resolve dependency cycle
rebase and re import PageableExecutionUtils

Thank you for taking care of it.

schauder pushed a commit that referenced this pull request Nov 3, 2020
@schauder
Copy link
Contributor

schauder commented Nov 3, 2020

Thanks, that's squashed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants