-
Notifications
You must be signed in to change notification settings - Fork 378
Docs: Add Person entity example to JDBC getting started section #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ruturajjadhav07
wants to merge
3
commits into
spring-projects:main
from
ruturajjadhav07:docs/add-person-entity-example
Closed
Docs: Add Person entity example to JDBC getting started section #2146
ruturajjadhav07
wants to merge
3
commits into
spring-projects:main
from
ruturajjadhav07:docs/add-person-entity-example
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: “[github]” <ruturajjadhav122@gmail.com>
e5419e1 to
c1711eb
Compare
schauder
added a commit
that referenced
this pull request
Oct 20, 2025
Remove name from Table annotation, since it would force the table name to be lower case. See #2146
schauder
pushed a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: “[github]” <ruturajjadhav122@gmail.com> Closes #2146
schauder
added a commit
that referenced
this pull request
Oct 20, 2025
Remove name from Table annotation, since it would force the table name to be lower case. See #2146
schauder
pushed a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: “[github]” <ruturajjadhav122@gmail.com> Closes #2146
schauder
added a commit
that referenced
this pull request
Oct 20, 2025
Remove name from Table annotation, since it would force the table name to be lower case. See #2146
schauder
pushed a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: “[github]” <ruturajjadhav122@gmail.com> Closes #2146
schauder
added a commit
that referenced
this pull request
Oct 20, 2025
Remove name from Table annotation, since it would force the table name to be lower case. See #2146
|
This is merged. Thanks for the contribution. |
Thanks, @schauder , for reviewing and merging this PR! Appreciate the polishing and final touches! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Getting Started with JDBC section of the documentation by adding the missing
Personentity class to the example.Previously, the docs showed
PersonRepository,MyService, andApplicationConfigwithout the corresponding entity, which could confuse new users.By including the entity definition, the example is now self-contained and easier to follow.
Example Change