Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker secrets api as a property source [SPR-17428] #21961

Closed
spring-projects-issues opened this issue Oct 24, 2018 · 4 comments
Closed

Support docker secrets api as a property source [SPR-17428] #21961

spring-projects-issues opened this issue Oct 24, 2018 · 4 comments
Labels
in: core status: declined

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 24, 2018

Caleb Cushing opened SPR-17428 and commented

The secrets API from inside fo a container, which is what I'm talking about is simply

/run/secrets/keyname (value is the contents of the file)

it appears that having a keyname that contains dots is allowed, so spring could simply look at that directory and for files with the same key name as they would be in a properties file.

https://docs.docker.com/engine/swarm/secrets/
https://diogomonica.com/2017/03/27/why-you-shouldnt-use-env-variables-for-secret-data/


No further details from SPR-17428

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 30, 2018

Stéphane Nicoll commented

I am not sure why this was reported here. If this is about looking at the environment to figure out that file exists and then "auto-create" a PropertySource for it, it doesn't belong as a low-level framework feature IMO.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 30, 2018

Caleb Cushing commented

I guess I see it as a file/directory property source, where each file contains one and only one property value, and the key is the name of the file. which I don't believe exists? maybe it does and I can't find it? this doesn't feel disimilar from ResourcePropertySource, except that's one file, this is many. I feel like this is more about having a class that can be pointed at a directory and use those files as a property source. Spring Boot then could use said class to autoconfigure.

@spring-projects-issues spring-projects-issues added status: waiting-for-triage type: enhancement in: core and removed type: enhancement labels Jan 11, 2019
@bclozel
Copy link
Member

@bclozel bclozel commented Apr 2, 2020

Might be related to spring-projects/spring-boot#19990

@bclozel
Copy link
Member

@bclozel bclozel commented Feb 18, 2022

Closing as this has been addressed in Spring Boot.

@bclozel bclozel closed this as completed Feb 18, 2022
@bclozel bclozel added status: declined and removed status: waiting-for-triage labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: declined
Projects
None yet
Development

No branches or pull requests

2 participants