Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker secrets api as a property source [SPR-17428] #21961

Open
spring-issuemaster opened this issue Oct 24, 2018 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 24, 2018

Caleb Cushing opened SPR-17428 and commented

The secrets API from inside fo a container, which is what I'm talking about is simply

/run/secrets/keyname (value is the contents of the file)

it appears that having a keyname that contains dots is allowed, so spring could simply look at that directory and for files with the same key name as they would be in a properties file.

https://docs.docker.com/engine/swarm/secrets/
https://diogomonica.com/2017/03/27/why-you-shouldnt-use-env-variables-for-secret-data/


No further details from SPR-17428

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 30, 2018

Stéphane Nicoll commented

I am not sure why this was reported here. If this is about looking at the environment to figure out that file exists and then "auto-create" a PropertySource for it, it doesn't belong as a low-level framework feature IMO.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 30, 2018

Caleb Cushing commented

I guess I see it as a file/directory property source, where each file contains one and only one property value, and the key is the name of the file. which I don't believe exists? maybe it does and I can't find it? this doesn't feel disimilar from ResourcePropertySource, except that's one file, this is many. I feel like this is more about having a class that can be pointed at a directory and use those files as a property source. Spring Boot then could use said class to autoconfigure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.