Configured adapter for @HttpExchange proxy group is ignored (7.0.0-RC2)

[ch4mpy]

Shouldn't the ProxyHttpServiceGroup::createProxies method set the proxyFactoryBuilder's exchangeAdapter only if it isn't set already?

As already reported in spring-projects/spring-boot#47855, I'm trying to integrate my existing RestClient and WebClient auto-configuration with what is added to Boot 4.0.0-RC1. However, whatever I configure with the following is ignored:

@Configuration
@ImportHttpServices(group = "bidule", types = {BiduleApi.class})
@ImportHttpServices(group = "machin", types = {MachinApi.class})
public class RestConfiguration {

  @Bean
  RestClientHttpServiceGroupConfigurer groupConfigurer(RestClient biduleClient,
      RestClient machinClient) {
    return groups -> {
      groups.forEachGroup((group, clientBuilder, factoryBuilder) -> {
        if ("bidule".equals(group.name())) {
          factoryBuilder.exchangeAdapter(RestClientAdapter.create(biduleClient));
        } else if ("machin".equals(group.name())) {
          factoryBuilder.exchangeAdapter(RestClientAdapter.create(machinClient));
        }
      });
    };
  }
}

[oscarfanchin]

The issue has not been analyzed yet, I think it will take some time, for the auto config of the clients (without security) I use this starter httpexchange-spring-boot-starter, since I understood the new functionality that gives you problems it should replace it

[ch4mpy]

@oscarfanchin, no, httpexchange-spring-boot-starter is not an alternative as:

• As far as I know, it doesn't allow switching the underlying REST client @Bean to use (RestClient or WebClient) with one that isn't auto-configured by httpexchange-spring-boot-starter itself. In the sample above, biduleClient and machinClient are such beans.
• Options for the underlying REST client bean auto-configured by httpexchange-spring-boot-starter are not enough for my needs. I happen to work behind an HTTP proxy, the APIs I call require different authorization mechanisms, and some internal APIs use self-signed SSL certificates, requiring me to tweak the SSL bundles.

[rstoyanchev]

You mean to provide a fully configured client, but currently we assume the client is built through group configurer mechanism with participation from Boot (for properties, customizers, etc), Spring Security, Spring Cloud, etc, to bring advanced config like you mention under #35728.

We can support this, but setting the HttpExchangeAdatper is a rather indirect way. We could provide a first class option to set the client (instance) for a group, and it would signal to us that there is no need to initialize and build a client.

Is it typically once client instance per group?

[ch4mpy]

We could provide a first class option to set the client (instance) for a group, and it would signal to us that there is no need to initialize and build a client

@rstoyanchev that would be great.

My need is to de-couple the group and client:

• a client might be used for sevral groups
• a client might be used not only by @HttpExchange proxies: the client used by a group could be injected and used directly by any @Component (like a @Service or @Controller)
• the client for a group might be configured upfront of the group definition (with something else than the "official" Boot DSL for @HttpExchange proxies)

I realized only this morning that new methods on the RestClient.Builder and WebClient.Builder to set all properties from another instance (or an already built client) could do the trick without touching the ProxyHttpServiceGroup.

If the client builder for a @HttpExchange proxy group can be configured from an already configured client (or builder), then we can reuse this already defined client(Builder) for several groups, and for injection in components.