Fix 500 error caused by If-Modified-Since=0 HTTP header #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit a 500 error would be bubbled up to the user when the If-Modified-Since header was passed to the backend with a value of 0. In this fix, the zero value is explicitly handled (in same way as with a null value) by returning -1 to the caller. Issue: SPR-14144
|
As discussed on SPR-14144, I've taken a slightly broader approach. Thanks for raising this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.
Prior to this commit a 500 error would be bubbled up to the user when the
If-Modified-Since header was passed to the backend with a value of 0.
In this fix, the zero value is explicitly handled (in same way as with a null
value) by returning -1 to the caller.
Issue: SPR-14144