Skip to content

MimeTypeUtils no longer cache MediaType.MULTIPART_FORM_DATA_VALUE #24768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

MimeTypeUtils no longer cache MediaType.MULTIPART_FORM_DATA_VALUE #24768

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ede8f1d
MimeTypeUtils no longer cache MediaType.MULTIPART_FORM_DATA_VALUE
Mar 24, 2020
aa8bebb
fixed bug MimeTypeUtils compile fail
Mar 24, 2020
16574a2
fixed bug MimeTypeUtils compile fail
Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion spring-core/src/main/java/org/springframework/util/MimeTypeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,20 @@ public abstract class MimeTypeUtils {
TEXT_XML = new MimeType("text", "xml");
}

/***
* Whether need cache.
* <p>For example "multipart/form-data; boundary=----WebKitFormBoundarymKzwdDkWNDNzQFP0",
* this mimeType with random characters, wastes LRU cache space, resulting in severe performance degradation.
* @param mimeType the mime type
* @return whether need cache
*/
private static boolean ensureMimeTypeRequiredCache(String mimeType){
// TODO constant
if(mimeType.startsWith("multipart/form-data;"))
return false;
return true;
}


/**
* Parse the given String into a single {@code MimeType}.
Expand All @@ -193,7 +207,9 @@ public static MimeType parseMimeType(String mimeType) {
if (!StringUtils.hasLength(mimeType)) {
throw new InvalidMimeTypeException(mimeType, "'mimeType' must not be empty");
}
return cachedMimeTypes.get(mimeType);
if (ensureMimeTypeRequiredCache(mimeType))
return cachedMimeTypes.get(mimeType);
return parseMimeTypeInternal(mimeType);
}

private static MimeType parseMimeTypeInternal(String mimeType) {
Expand Down