Skip to content

Adds customization option for Executors coming from AsyncConfigurers #27953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcingrzejszczak wants to merge 2 commits into from
Closed

Adds customization option for Executors coming from AsyncConfigurers #27953

marcingrzejszczak wants to merge 2 commits into from

Conversation

@marcingrzejszczak
Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Jan 19, 2022 •
edited
Loading

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 19, 2022
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Feb 25, 2022
@marcingrzejszczak marcingrzejszczak marked this pull request as ready for review April 15, 2022 11:19
@marcingrzejszczak marcingrzejszczak mentioned this pull request May 18, 2022
Closed
nkonev
nkonev reviewed May 19, 2022
View reviewed changes
...text/src/main/java/org/springframework/scheduling/annotation/AbstractAsyncConfiguration.java Outdated
Copy link

@nkonev nkonev May 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.executor won't be set if customizers aren't available. Is this desired ?

Copy link
Contributor Author

@marcingrzejszczak marcingrzejszczak May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, good catch

@maradanasai
Copy link

maradanasai commented Aug 21, 2023

This is happening for us when we are migrating to latest. Here is the sample reproducible code https://github.com/maradanasai/otel-async-exper.git . Using spring boot 2.7.14 and spring cloud 2021.0.8 version with jdk 17. It is blocking migrating to latest versions. Please fix this

@snicoll
Copy link
Member

snicoll commented Aug 22, 2023

Sorry for the delay. Unfortunately, we can't add such an interface in 5.3.x at this time, in particular as it is not required in the next generation of micrometer tracing and the framework. I think Sleuth should rather reintroduce the BPP that used to swap the executor, or document how it can be done. This also brings more consistency with what we have to do in the next major release.

@snicoll snicoll closed this Aug 22, 2023
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nkonev nkonev nkonev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marcingrzejszczak @maradanasai @snicoll @nkonev @rstoyanchev @spring-projects-issues