Skip to content

Regression on value class parameter handling#36665

Open
sgerke-1L wants to merge 2 commits intospring-projects:mainfrom
sgerke-1L:fix-handler
Open

Regression on value class parameter handling#36665
sgerke-1L wants to merge 2 commits intospring-projects:mainfrom
sgerke-1L:fix-handler

Conversation

@sgerke-1L
Copy link
Copy Markdown

@sgerke-1L sgerke-1L commented Apr 17, 2026

The fix in #36449 introduces a regression related to the handling of value class conversion. In particular, passing e.g. UUID for an argument of type ValueClass(val value: UUID) doesn't work anymore. This is required to make ValueClass parameters work, see added integration tests.

Fix description

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 17, 2026
@sgerke-1L sgerke-1L force-pushed the fix-handler branch 2 times, most recently from aee7617 to 0b4084f Compare April 17, 2026 11:50
Signed-off-by: Sigurd Gerke <sigurd.gerke@onedata.de>
Signed-off-by: Sigurd Gerke <sigurd.gerke@onedata.de>
@sdeleuze
Copy link
Copy Markdown
Contributor

I will try to leverage this PR to fix this regression caused by #36449, the fix will have to be backported to 6.2.x.

@sdeleuze sdeleuze changed the title Improve value class handling after #36449 Regression on value class web handling Apr 27, 2026
@sgerke-1L
Copy link
Copy Markdown
Author

Thank you! Let me know if there is anything I can help with.

@sdeleuze sdeleuze added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Apr 27, 2026
@sdeleuze sdeleuze changed the title Regression on value class web handling Regression on value class parameter handling Apr 27, 2026
@sdeleuze
Copy link
Copy Markdown
Contributor

Were the integration tests required to exercise some broken code paths or were they just added as additional tests "in case of" ?

@sgerke-1L
Copy link
Copy Markdown
Author

sgerke-1L commented Apr 27, 2026

Suspending handler method with nullable value class request param and suspendingValueClass exhibit the regression introduced in #36665 . The others were green already, and I added them to document what's currently working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: regression A bug that is also a regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants