Require closing comment and blank line in file headers #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therepanic
commented
Nov 13, 2025
spring-grpc-core/src/main/java/org/springframework/grpc/server/service/GrpcService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
force-pushed
the
checkstyle-header-polish
branch
from
e40200d to
d3c1172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that our
checkstyle-headeris different from othercheckstyle-headerfiles in other Spring projects. We could bring the copyright header to the same format. In principle, this was what it was all about, but now it's not exactly happening.I added in
checkstyle-header.txtnew rules that make sure that the header is closed, that there is an empty line, and that other code can follow. There are similar rules in other spring projects, such as spring security or spring pulsar.