Use JSpecify for nullability constraints #302
Conversation
onobc
force-pushed
the
GH-192-jspecify
branch
2 times, most recently
from
19304c6 to
113d9e6
Compare
Resolves spring-projects#192 Signed-off-by: onobc <chris.bono@gmail.com>
onobc
force-pushed
the
GH-192-jspecify
branch
from
113d9e6 to
5a81971
Compare
| * Core module for Spring gRPC. | ||
| */ | ||
| @NullMarked | ||
| package org.springframework.grpc; |
There was a problem hiding this comment.
Hey @onobc I believe that actually every package needs to be annotated, right? Not only the top-level one, due to the limitations of how NullAway+JSpecify do things, its not inherited from the root to all sub packages.
For example, searching inside Spring Framework we have 356 mathces for files package-info.java with NullMarked inside:
repo:spring-projects/spring-framework "@NullMarked" path:package-info.java
So to truly benefit from JSpecify I believe Spring gRPC still has some package-info to add, right?
There was a problem hiding this comment.
👋🏻 @lobaorn-bitso - great catch! Absolutely have to put a package-info.java in each package directory. I will get this fixed shortly.
There was a problem hiding this comment.
Hi, @onobc. If you don't mind or are unavailable, I can do PR for this myself.
3 participants
Resolves #192