Fix: Missing secure field in ChannelConfig.copy() method #327
Conversation
The copy method implemented in GrpcClientProperties.ChannelConfig was missing a class field. The <secure> field was not copied into the destination instance inside the copy method. This adds the missing field and also updates the unit tests to ensure the field is properly copied into the destination instance Signed-off-by: Vahid Ramezani <vahid.ramezani.2014@gmail.com>
Adds author tags to changes files in previous commit. Original pull request #327 Signed-off-by: onobc <chris.bono@gmail.com>
|
Great 🐞 catch! Thanks for another great contribution. Your original commit closed this PR. I also added a minor polishing commit.
Yes, I know that having the specific fields becomes a brittle maintenance point (this PR is the case and point of that). In general, Spring projects tend to avoid reflection for these cases and instead make sure we have proper test coverage. Another thing to note that we are likely to push back on any changes that are in the auto-configuration modules as they will move into Spring Boot 4.1 (#234). |
2 participants
The secure field is not being copied in the ChannelConfig.copy() method, which can lead to incorrect channel configuration when a channel config is copied after modifying the secure flag from its default value. For example while setting the
spring.grpc.client.default-channel.securetofalseand then call thegetChannel()with an unknown name the secure field would still be set totruein the returned instance.Changes
Note
I also thought about how to enforce future extensions of the ChannelConfig to modify the copy method but I could think of nothing but using the
java.land.reflectapi which I currently think is not a preferred option in this project. But I will accept any other recomendations.