GH-10487: Add STOMP CONNECT frame from the client
#10488
Merged
+78
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#10487 * Fix `WebSocketInboundChannelAdapter` to register own client session in the `StompSubProtocolHandler` for a proper correlation for upcoming messages from the server * Fix `WebSocketOutboundMessageHandlerTests` to produce required STOMP `CONNECT` before publishing data Cherry-pick to `6.5.x` & `6.4.x`
|
NOTE: the cherry-pick might require some manual conflict fixes since there is no JSpecify in |
cppwfs
requested changes
Oct 16, 2025
...n/java/org/springframework/integration/websocket/inbound/WebSocketInboundChannelAdapter.java
Show resolved
Hide resolved
...n/java/org/springframework/integration/websocket/inbound/WebSocketInboundChannelAdapter.java
Show resolved
Hide resolved
...org/springframework/integration/websocket/outbound/WebSocketOutboundMessageHandlerTests.java
Show resolved
Hide resolved
|
@cppwfs , please, give this a priority. |
artembilan
added a commit
that referenced
this pull request
Oct 16, 2025
Fixes: #10487 * Fix `WebSocketInboundChannelAdapter` to register own client session in the `StompSubProtocolHandler` for a proper correlation for upcoming messages from the server * Fix `WebSocketOutboundMessageHandlerTests` to produce required STOMP `CONNECT` before publishing data **Auto-cherry-pick to `6.4.x`** # Conflicts: # spring-integration-websocket/src/main/java/org/springframework/integration/websocket/inbound/WebSocketInboundChannelAdapter.java
spring-builds
pushed a commit
that referenced
this pull request
Oct 16, 2025
Fixes: #10487 * Fix `WebSocketInboundChannelAdapter` to register own client session in the `StompSubProtocolHandler` for a proper correlation for upcoming messages from the server * Fix `WebSocketOutboundMessageHandlerTests` to produce required STOMP `CONNECT` before publishing data # Conflicts: # spring-integration-websocket/src/main/java/org/springframework/integration/websocket/inbound/WebSocketInboundChannelAdapter.java (cherry picked from commit 30d4159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10487
WebSocketInboundChannelAdapterto register own client session in theStompSubProtocolHandlerfor a proper correlation for upcoming messages from the serverWebSocketOutboundMessageHandlerTeststo produce required STOMPCONNECTbefore publishing dataCherry-pick to
6.5.x&6.4.x